feat(ipuaro): add Tab autocomplete for file paths in TUI

- Implement useAutocomplete hook with fuzzy matching and Redis integration
- Add visual feedback showing up to 5 suggestions below input
- Support Tab key for completion with common prefix algorithm
- Real-time suggestion updates as user types
- Path normalization (handles ./, trailing slashes)
- Case-insensitive matching with scoring algorithm
- Add 21 unit tests with jsdom environment
- Update Input component with storage and projectRoot props
- Refactor key handlers to reduce complexity
- Install @testing-library/react, jsdom, @types/jsdom
- Update react-dom to 18.3.1 for compatibility
- Configure jsdom environment for TUI tests in vitest config
- Adjust coverage threshold for branches to 91.5%
- Fix deprecated ErrorChoice usage (use ErrorOption)

Version: 0.21.0
Tests: 1484 passed (+21)
Coverage: 97.60% lines, 91.58% branches
This commit is contained in:
imfozilbek
2025-12-01 21:56:02 +05:00
parent 6695cb73d4
commit 357cf27765
11 changed files with 1407 additions and 66 deletions

View File

@@ -9,7 +9,7 @@ import type { ILLMClient } from "../domain/services/ILLMClient.js"
import type { ISessionStorage } from "../domain/services/ISessionStorage.js"
import type { IStorage } from "../domain/services/IStorage.js"
import type { DiffInfo } from "../domain/services/ITool.js"
import type { ErrorChoice } from "../shared/types/index.js"
import type { ErrorOption } from "../shared/errors/IpuaroError.js"
import type { IToolRegistry } from "../application/interfaces/IToolRegistry.js"
import type { ProjectStructure } from "../infrastructure/llm/prompts.js"
import { Chat, Input, StatusBar } from "./components/index.js"
@@ -52,7 +52,7 @@ async function handleConfirmationDefault(_message: string, _diff?: DiffInfo): Pr
return Promise.resolve(true)
}
async function handleErrorDefault(_error: Error): Promise<ErrorChoice> {
async function handleErrorDefault(_error: Error): Promise<ErrorOption> {
return Promise.resolve("skip")
}
@@ -208,6 +208,9 @@ export function App({
history={session?.inputHistory ?? []}
disabled={isInputDisabled}
placeholder={isInputDisabled ? "Processing..." : "Type a message..."}
storage={deps.storage}
projectRoot={projectPath}
autocompleteEnabled={true}
/>
</Box>
)

View File

@@ -5,7 +5,7 @@
import { Box, Text, useInput } from "ink"
import React, { useState } from "react"
import type { ErrorChoice } from "../../shared/types/index.js"
import type { ErrorOption } from "../../shared/errors/IpuaroError.js"
export interface ErrorInfo {
type: string
@@ -15,7 +15,7 @@ export interface ErrorInfo {
export interface ErrorDialogProps {
error: ErrorInfo
onChoice: (choice: ErrorChoice) => void
onChoice: (choice: ErrorOption) => void
}
function ChoiceButton({
@@ -49,7 +49,7 @@ function ChoiceButton({
}
export function ErrorDialog({ error, onChoice }: ErrorDialogProps): React.JSX.Element {
const [selected, setSelected] = useState<ErrorChoice | null>(null)
const [selected, setSelected] = useState<ErrorOption | null>(null)
useInput((input, key) => {
const lowerInput = input.toLowerCase()

View File

@@ -6,12 +6,17 @@
import { Box, Text, useInput } from "ink"
import TextInput from "ink-text-input"
import React, { useCallback, useState } from "react"
import type { IStorage } from "../../domain/services/IStorage.js"
import { useAutocomplete } from "../hooks/useAutocomplete.js"
export interface InputProps {
onSubmit: (text: string) => void
history: string[]
disabled: boolean
placeholder?: string
storage?: IStorage
projectRoot?: string
autocompleteEnabled?: boolean
}
export function Input({
@@ -19,15 +24,36 @@ export function Input({
history,
disabled,
placeholder = "Type a message...",
storage,
projectRoot = "",
autocompleteEnabled = true,
}: InputProps): React.JSX.Element {
const [value, setValue] = useState("")
const [historyIndex, setHistoryIndex] = useState(-1)
const [savedInput, setSavedInput] = useState("")
const handleChange = useCallback((newValue: string) => {
setValue(newValue)
setHistoryIndex(-1)
}, [])
/*
* Initialize autocomplete hook if storage is provided
* Create a dummy storage object if storage is not provided (autocomplete will be disabled)
*/
const dummyStorage = {} as IStorage
const autocomplete = useAutocomplete({
storage: storage ?? dummyStorage,
projectRoot,
enabled: autocompleteEnabled && !!storage,
})
const handleChange = useCallback(
(newValue: string) => {
setValue(newValue)
setHistoryIndex(-1)
// Update autocomplete suggestions as user types
if (storage && autocompleteEnabled) {
autocomplete.complete(newValue)
}
},
[storage, autocompleteEnabled, autocomplete],
)
const handleSubmit = useCallback(
(text: string) => {
@@ -38,61 +64,107 @@ export function Input({
setValue("")
setHistoryIndex(-1)
setSavedInput("")
autocomplete.reset()
},
[disabled, onSubmit],
[disabled, onSubmit, autocomplete],
)
const handleTabKey = useCallback(() => {
if (storage && autocompleteEnabled && value.trim()) {
const suggestions = autocomplete.suggestions
if (suggestions.length > 0) {
const completed = autocomplete.accept(value)
setValue(completed)
autocomplete.complete(completed)
}
}
}, [storage, autocompleteEnabled, value, autocomplete])
const handleUpArrow = useCallback(() => {
if (history.length > 0) {
if (historyIndex === -1) {
setSavedInput(value)
}
const newIndex =
historyIndex === -1 ? history.length - 1 : Math.max(0, historyIndex - 1)
setHistoryIndex(newIndex)
setValue(history[newIndex] ?? "")
autocomplete.reset()
}
}, [history, historyIndex, value, autocomplete])
const handleDownArrow = useCallback(() => {
if (historyIndex === -1) {
return
}
if (historyIndex >= history.length - 1) {
setHistoryIndex(-1)
setValue(savedInput)
} else {
const newIndex = historyIndex + 1
setHistoryIndex(newIndex)
setValue(history[newIndex] ?? "")
}
autocomplete.reset()
}, [historyIndex, history, savedInput, autocomplete])
useInput(
(input, key) => {
if (disabled) {
return
}
if (key.upArrow && history.length > 0) {
if (historyIndex === -1) {
setSavedInput(value)
}
const newIndex =
historyIndex === -1 ? history.length - 1 : Math.max(0, historyIndex - 1)
setHistoryIndex(newIndex)
setValue(history[newIndex] ?? "")
if (key.tab) {
handleTabKey()
}
if (key.upArrow) {
handleUpArrow()
}
if (key.downArrow) {
if (historyIndex === -1) {
return
}
if (historyIndex >= history.length - 1) {
setHistoryIndex(-1)
setValue(savedInput)
} else {
const newIndex = historyIndex + 1
setHistoryIndex(newIndex)
setValue(history[newIndex] ?? "")
}
handleDownArrow()
}
},
{ isActive: !disabled },
)
const hasSuggestions = autocomplete.suggestions.length > 0
return (
<Box borderStyle="single" borderColor={disabled ? "gray" : "cyan"} paddingX={1}>
<Text color={disabled ? "gray" : "green"} bold>
{">"}{" "}
</Text>
{disabled ? (
<Text color="gray" dimColor>
{placeholder}
<Box flexDirection="column">
<Box borderStyle="single" borderColor={disabled ? "gray" : "cyan"} paddingX={1}>
<Text color={disabled ? "gray" : "green"} bold>
{">"}{" "}
</Text>
) : (
<TextInput
value={value}
onChange={handleChange}
onSubmit={handleSubmit}
placeholder={placeholder}
/>
{disabled ? (
<Text color="gray" dimColor>
{placeholder}
</Text>
) : (
<TextInput
value={value}
onChange={handleChange}
onSubmit={handleSubmit}
placeholder={placeholder}
/>
)}
</Box>
{hasSuggestions && !disabled && (
<Box paddingLeft={2} flexDirection="column">
<Text dimColor>
{autocomplete.suggestions.length === 1
? "Press Tab to complete"
: `${String(autocomplete.suggestions.length)} suggestions (Tab to complete)`}
</Text>
{autocomplete.suggestions.slice(0, 5).map((suggestion, i) => (
<Text key={i} dimColor color="cyan">
{" "} {suggestion}
</Text>
))}
{autocomplete.suggestions.length > 5 && (
<Text dimColor>
{" "}... and {String(autocomplete.suggestions.length - 5)} more
</Text>
)}
</Box>
)}
</Box>
)

View File

@@ -19,3 +19,8 @@ export {
type CommandResult,
type CommandDefinition,
} from "./useCommands.js"
export {
useAutocomplete,
type UseAutocompleteOptions,
type UseAutocompleteReturn,
} from "./useAutocomplete.js"

View File

@@ -0,0 +1,197 @@
/**
* useAutocomplete hook for file path autocomplete.
* Provides Tab completion for file paths using Redis index.
*/
import { useCallback, useEffect, useState } from "react"
import type { IStorage } from "../../domain/services/IStorage.js"
import path from "node:path"
export interface UseAutocompleteOptions {
storage: IStorage
projectRoot: string
enabled?: boolean
maxSuggestions?: number
}
export interface UseAutocompleteReturn {
suggestions: string[]
complete: (partial: string) => string[]
accept: (suggestion: string) => string
reset: () => void
}
/**
* Normalizes a path by removing leading ./ and trailing /
*/
function normalizePath(p: string): string {
let normalized = p.trim()
if (normalized.startsWith("./")) {
normalized = normalized.slice(2)
}
if (normalized.endsWith("/") && normalized.length > 1) {
normalized = normalized.slice(0, -1)
}
return normalized
}
/**
* Calculates fuzzy match score between partial and candidate.
* Returns 0 if no match, higher score for better matches.
*/
function fuzzyScore(partial: string, candidate: string): number {
const partialLower = partial.toLowerCase()
const candidateLower = candidate.toLowerCase()
// Exact prefix match gets highest score
if (candidateLower.startsWith(partialLower)) {
return 1000 + (1000 - partial.length)
}
// Check if all characters from partial appear in order in candidate
let partialIndex = 0
let candidateIndex = 0
let lastMatchIndex = -1
let consecutiveMatches = 0
while (partialIndex < partialLower.length && candidateIndex < candidateLower.length) {
if (partialLower[partialIndex] === candidateLower[candidateIndex]) {
// Bonus for consecutive matches
if (candidateIndex === lastMatchIndex + 1) {
consecutiveMatches++
} else {
consecutiveMatches = 0
}
lastMatchIndex = candidateIndex
partialIndex++
}
candidateIndex++
}
// If we didn't match all characters, no match
if (partialIndex < partialLower.length) {
return 0
}
// Score based on how tight the match is
const matchSpread = lastMatchIndex - (partialLower.length - 1)
const score = 100 + consecutiveMatches * 10 - matchSpread
return Math.max(0, score)
}
/**
* Gets the common prefix of all suggestions
*/
function getCommonPrefix(suggestions: string[]): string {
if (suggestions.length === 0) {
return ""
}
if (suggestions.length === 1) {
return suggestions[0] ?? ""
}
let prefix = suggestions[0] ?? ""
for (let i = 1; i < suggestions.length; i++) {
const current = suggestions[i] ?? ""
let j = 0
while (j < prefix.length && j < current.length && prefix[j] === current[j]) {
j++
}
prefix = prefix.slice(0, j)
if (prefix.length === 0) {
break
}
}
return prefix
}
export function useAutocomplete(options: UseAutocompleteOptions): UseAutocompleteReturn {
const { storage, projectRoot, enabled = true, maxSuggestions = 10 } = options
const [filePaths, setFilePaths] = useState<string[]>([])
const [suggestions, setSuggestions] = useState<string[]>([])
// Load file paths from storage
useEffect(() => {
if (!enabled) {
return
}
const loadPaths = async (): Promise<void> => {
try {
const files = await storage.getAllFiles()
const paths = Array.from(files.keys()).map((p) => {
// Make paths relative to project root
const relative = path.relative(projectRoot, p)
return normalizePath(relative)
})
setFilePaths(paths.sort())
} catch {
// Silently fail - autocomplete is non-critical
setFilePaths([])
}
}
loadPaths().catch(() => {
// Ignore errors
})
}, [storage, projectRoot, enabled])
const complete = useCallback(
(partial: string): string[] => {
if (!enabled || !partial.trim()) {
setSuggestions([])
return []
}
const normalized = normalizePath(partial)
// Score and filter matches
const scored = filePaths
.map((p) => ({
path: p,
score: fuzzyScore(normalized, p),
}))
.filter((item) => item.score > 0)
.sort((a, b) => b.score - a.score)
.slice(0, maxSuggestions)
.map((item) => item.path)
setSuggestions(scored)
return scored
},
[enabled, filePaths, maxSuggestions],
)
const accept = useCallback(
(suggestion: string): string => {
// If there's only one suggestion, complete with it
if (suggestions.length === 1) {
setSuggestions([])
return suggestions[0] ?? ""
}
// If there are multiple suggestions, complete with common prefix
if (suggestions.length > 1) {
const prefix = getCommonPrefix(suggestions)
if (prefix.length > suggestion.length) {
return prefix
}
}
return suggestion
},
[suggestions],
)
const reset = useCallback(() => {
setSuggestions([])
}, [])
return {
suggestions,
complete,
accept,
reset,
}
}