Files
imfozilbek 3fecc98676 feat: add dependency direction enforcement (v0.4.0)
Implement dependency direction detection to enforce Clean Architecture rules:
- Domain layer can only import from Domain and Shared
- Application layer can only import from Domain, Application, and Shared
- Infrastructure layer can import from all layers
- Shared layer can be imported by all layers

Added:
- IDependencyDirectionDetector interface in domain layer
- DependencyViolation value object with detailed suggestions and examples
- DependencyDirectionDetector implementation in infrastructure
- Integration with AnalyzeProject use case
- New DEPENDENCY_DIRECTION rule in constants
- 43 comprehensive tests covering all scenarios (100% passing)
- Good and bad examples in examples directory

Improvements:
- Optimized extractLayerFromImport method to reduce complexity
- Fixed indentation in DependencyGraph.ts
- Updated getExampleFix to avoid false positives in old detector

Test Results:
- All 261 tests passing
- Build successful
- Self-check: 0 architecture violations in src code
2025-11-24 18:31:41 +05:00

92 lines
2.4 KiB
TypeScript

/**
* ✅ GOOD: Application layer with correct dependencies
*
* Application should only import from:
* - Domain layer
* - Other application files
* - Shared utilities
*
* Application should NOT import from:
* - Infrastructure layer
*/
import { User } from "../domain/entities/User"
import { Email } from "../domain/value-objects/Email"
import { UserId } from "../domain/value-objects/UserId"
import { IUserRepository } from "../domain/repositories/IUserRepository"
import { Result } from "../../../src/shared/types/Result"
/**
* ✅ Use case depends on domain interfaces (IUserRepository)
* NOT on infrastructure implementations
*/
export class CreateUser {
constructor(private readonly userRepo: IUserRepository) {}
async execute(request: CreateUserRequest): Promise<Result<UserResponseDto>> {
const emailResult = Email.create(request.email)
if (emailResult.isFailure) {
return Result.fail(emailResult.error)
}
const userId = UserId.generate()
const user = new User(userId, emailResult.value)
await this.userRepo.save(user)
return Result.ok(UserMapper.toDto(user))
}
}
/**
* ✅ DTO in application layer
*/
export interface CreateUserRequest {
email: string
name: string
}
export interface UserResponseDto {
id: string
email: string
createdAt: string
}
/**
* ✅ Mapper in application layer converting domain to DTO
*/
export class UserMapper {
static toDto(user: User): UserResponseDto {
return {
id: user.getId().getValue(),
email: user.getEmail().getValue(),
createdAt: user.getCreatedAt().toISOString(),
}
}
}
/**
* ✅ Application defines Port (interface) for email service
* Infrastructure will provide the Adapter (implementation)
*/
export interface IEmailService {
sendWelcomeEmail(email: string): Promise<void>
}
export class SendWelcomeEmail {
constructor(
private readonly userRepo: IUserRepository,
private readonly emailService: IEmailService,
) {}
async execute(userId: string): Promise<Result<void>> {
const user = await this.userRepo.findById(UserId.from(userId))
if (!user) {
return Result.fail("User not found")
}
await this.emailService.sendWelcomeEmail(user.getEmail().getValue())
return Result.ok()
}
}